This is an automated email from the ASF dual-hosted git repository.
alenka pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new 9c247a52e1 GH-48446: [Python] Remove todo of schema=name mismatch in
`record_batches` (#48447)
9c247a52e1 is described below
commit 9c247a52e1e44720f31c2201cc601fb27459beba
Author: Hyukjin Kwon <[email protected]>
AuthorDate: Fri Dec 12 17:36:53 2025 +0900
GH-48446: [Python] Remove todo of schema=name mismatch in `record_batches`
(#48447)
### Rationale for this change
https://github.com/apache/arrow/blob/6456944f5092dedb3f80d9bc80400e857d6571c7/python/pyarrow/tests/strategies.py#L393-L394
https://github.com/apache/arrow/commit/2b36521e52 fixed the issue by:
```diff
- return pa.RecordBatch.from_arrays(children, names=schema)
+ return pa.RecordBatch.from_arrays(children, schema=schema)
```
so this todo can be removed.
### What changes are included in this PR?
This PR removes an obsolete todo.
### Are these changes tested?
No, I removed a comment and did not test this.
### Are there any user-facing changes?
No, test-only.
* GitHub Issue: #48446
Authored-by: Hyukjin Kwon <[email protected]>
Signed-off-by: AlenkaF <[email protected]>
---
python/pyarrow/tests/strategies.py | 2 --
1 file changed, 2 deletions(-)
diff --git a/python/pyarrow/tests/strategies.py
b/python/pyarrow/tests/strategies.py
index 450cce74f1..5ce5602298 100644
--- a/python/pyarrow/tests/strategies.py
+++ b/python/pyarrow/tests/strategies.py
@@ -390,8 +390,6 @@ def record_batches(draw, type, rows=None, max_fields=None):
schema = draw(schemas(type, max_fields=max_fields))
children = [draw(arrays(field.type, size=rows)) for field in schema]
- # TODO(kszucs): the names and schema arguments are not consistent with
- # Table.from_array's arguments
return pa.RecordBatch.from_arrays(children, schema=schema)
