(arrow-rs) branch main updated: [Variant] Minor: Add comments to tickets for follow on items (#8092)

[alamb]

This is an automated email from the ASF dual-hosted git repository.

alamb pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git


The following commit(s) were added to refs/heads/main by this push:
     new 9a0010f70b [Variant] Minor: Add comments to tickets for follow on 
items (#8092)
9a0010f70b is described below

commit 9a0010f70b56c87a57d89c948ab13eb44e483746
Author: Andrew Lamb <and...@nerdnetworks.org>
AuthorDate: Wed Aug 13 10:45:35 2025 -0700

    [Variant] Minor: Add comments to tickets for follow on items (#8092)
    
    # Which issue does this PR close?
    
    
    - Follow on to https://github.com/apache/arrow-rs/pull/8021
    
    # Rationale for this change
    
    Let's add links to the relevant tickets in the code so future readers
    who encounter it can find the relevant context
    
    # What changes are included in this PR?
    
    Add comments with links to tickets
    
    # Are these changes tested?
    
    N/A (just comments)
    
    # Are there any user-facing changes?
    
    No
---
 parquet-variant-compute/src/variant_array.rs                | 3 ++-
 parquet-variant-compute/src/variant_get/output/primitive.rs | 6 +++---
 parquet-variant-compute/src/variant_get/output/variant.rs   | 2 ++
 3 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/parquet-variant-compute/src/variant_array.rs 
b/parquet-variant-compute/src/variant_array.rs
index d51df55062..f834df4177 100644
--- a/parquet-variant-compute/src/variant_array.rs
+++ b/parquet-variant-compute/src/variant_array.rs
@@ -227,6 +227,7 @@ impl VariantArray {
 #[derive(Debug)]
 pub enum ShreddingState {
     // TODO: add missing state where there is neither value nor typed_value
+    // https://github.com/apache/arrow-rs/issues/8088
     // Missing { metadata: BinaryViewArray },
     /// This variant has no typed_value field
     Unshredded {
@@ -342,7 +343,7 @@ fn typed_value_to_variant(typed_value: &ArrayRef, index: 
usize) -> Variant<'_, '
         _ => {
             // We shouldn't panic in production code, but this is a
             // placeholder until we implement more types
-            // TODO tickets: XXXX
+            // https://github.com/apache/arrow-rs/issues/8091
             debug_assert!(
                 false,
                 "Unsupported typed_value type: {:?}",
diff --git a/parquet-variant-compute/src/variant_get/output/primitive.rs 
b/parquet-variant-compute/src/variant_get/output/primitive.rs
index 36e4221e32..517635e791 100644
--- a/parquet-variant-compute/src/variant_get/output/primitive.rs
+++ b/parquet-variant-compute/src/variant_get/output/primitive.rs
@@ -93,7 +93,8 @@ impl<'a, T: ArrowPrimitiveVariant> OutputBuilder for 
PrimitiveOutputBuilder<'a,
 
             // if the typed value is null, decode the variant and extract the 
value
             if typed_value.is_null(i) {
-                // todo follow path
+                // TODO follow path
+                // https://github.com/apache/arrow-rs/issues/8086
                 let variant = variant_array.value(i);
                 let Some(value) = T::from_variant(&variant) else {
                     if self.cast_options.safe {
@@ -137,6 +138,7 @@ impl<'a, T: ArrowPrimitiveVariant> OutputBuilder for 
PrimitiveOutputBuilder<'a,
             Ok(typed_value.clone())
         } else {
             // TODO: try to cast the typed_value to the desired type?
+            // https://github.com/apache/arrow-rs/issues/8086
             Err(ArrowError::NotYetImplemented(format!(
                 "variant_get fully_shredded as {:?} with typed_value={:?} is 
not implemented yet",
                 self.as_type.data_type(),
@@ -162,5 +164,3 @@ impl ArrowPrimitiveVariant for Int32Type {
         variant.as_int32()
     }
 }
-
-// todo for other primitive types
diff --git a/parquet-variant-compute/src/variant_get/output/variant.rs 
b/parquet-variant-compute/src/variant_get/output/variant.rs
index 2c04111a53..c20949ce64 100644
--- a/parquet-variant-compute/src/variant_get/output/variant.rs
+++ b/parquet-variant-compute/src/variant_get/output/variant.rs
@@ -71,6 +71,7 @@ impl<'a> OutputBuilder for VariantOutputBuilder<'a> {
                 }
             }
             dt => {
+                // https://github.com/apache/arrow-rs/issues/8086
                 return Err(ArrowError::NotYetImplemented(format!(
                     "variant_get fully_shredded with typed_value={dt} is not 
implemented yet",
                 )));
@@ -104,6 +105,7 @@ impl<'a> OutputBuilder for VariantOutputBuilder<'a> {
                 }
             }
             dt => {
+                // https://github.com/apache/arrow-rs/issues/8087
                 return Err(ArrowError::NotYetImplemented(format!(
                     "variant_get fully_shredded with typed_value={dt} is not 
implemented yet",
                 )));