This is an automated email from the ASF dual-hosted git repository.

paleolimbot pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-nanoarrow.git


The following commit(s) were added to refs/heads/main by this push:
     new ed4ba0c7 fix(r): Ensure C23 version check works for clang16 (current 
GitHub Actions) (#801)
ed4ba0c7 is described below

commit ed4ba0c7a6e3fc3d94babcbb962735cb80b8a4f8
Author: Dewey Dunnington <[email protected]>
AuthorDate: Tue Aug 12 20:02:31 2025 -0500

    fix(r): Ensure C23 version check works for clang16 (current GitHub Actions) 
(#801)
    
    This was fixed in https://github.com/apache/arrow-nanoarrow/pull/742 but
    given the current R CI failure did not correctly identify all compilers
    + flags that define `alignof`/`alignas` (e.g., the current macos-latest
    GitHub actions).
    
    Hopefully the value of `202000L` won't cause problems with other
    compilers published around the same time. (I would have thought that
    compiling with a draft C standard was rare, but here we are...)
---
 thirdparty/flatcc/include/flatcc/portable/pstdalign.h | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/thirdparty/flatcc/include/flatcc/portable/pstdalign.h 
b/thirdparty/flatcc/include/flatcc/portable/pstdalign.h
index 989792eb..1737ca01 100644
--- a/thirdparty/flatcc/include/flatcc/portable/pstdalign.h
+++ b/thirdparty/flatcc/include/flatcc/portable/pstdalign.h
@@ -141,7 +141,10 @@ extern "C" {
 #endif /* __STDC__ */
 
 // For C23, alignas/alignof are keywords and will warn (-Wkeyword-macro) when 
#defined here
-#if !(defined(__STDC__) && __STDC__ && defined(__STDC_VERSION__) && 
__STDC_VERSION__ >= 202311L)
+// GH-801: 202000L is the value used by Apple clang-16 when compiling with 
-std=gnu2x (i.e.,
+// the draft standard at the time), which reflects the GitHub Actions runner 
at the time of this
+// writing.
+#if !(defined(__STDC__) && __STDC__ && defined(__STDC_VERSION__) && 
__STDC_VERSION__ >= 202000L)
 
 #ifndef alignas
 #define alignas _Alignas

Reply via email to