This is an automated email from the ASF dual-hosted git repository.
lidavidm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-adbc.git
The following commit(s) were added to refs/heads/main by this push:
new a73995580 test(c/driver_manager): Make DriverManifest::SetUp more
resilient (#3251)
a73995580 is described below
commit a7399558049b54b04b0d796b101f66af556b5315
Author: Bryce Mecum <[email protected]>
AuthorDate: Sat Aug 9 18:30:46 2025 -0700
test(c/driver_manager): Make DriverManifest::SetUp more resilient (#3251)
This fixes an occasional issue with the SetUp block of the
DriverManifest fixture. At least on my macOS system, if a previous test
runs fails before running TearDown, SetUp would fail on this assertion.
This changes the SetUp behavior so it re-uses the temporary directory.
---
c/driver_manager/adbc_driver_manager_test.cc | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/c/driver_manager/adbc_driver_manager_test.cc
b/c/driver_manager/adbc_driver_manager_test.cc
index afe296a4c..4d3ec15a8 100644
--- a/c/driver_manager/adbc_driver_manager_test.cc
+++ b/c/driver_manager/adbc_driver_manager_test.cc
@@ -414,11 +414,8 @@ class DriverManifest : public ::testing::Test {
}},
};
- auto temp_path = std::filesystem::temp_directory_path();
- temp_path /= "adbc_driver_manager_test";
-
- ASSERT_TRUE(std::filesystem::create_directories(temp_path));
- temp_dir = temp_path;
+ temp_dir = std::filesystem::temp_directory_path() /
"adbc_driver_manager_test";
+ std::filesystem::create_directories(temp_dir);
#endif
}