This is an automated email from the ASF dual-hosted git repository.
curth pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-adbc.git
The following commit(s) were added to refs/heads/main by this push:
new 8775b2078 fix(csharp/src/Drivers/Databricks): Set
enable_run_async_thrift default true (#3232)
8775b2078 is described below
commit 8775b207808ac02d537e73965cb6509f29ab78c5
Author: Jacky Hu <[email protected]>
AuthorDate: Mon Aug 4 20:15:55 2025 -0700
fix(csharp/src/Drivers/Databricks): Set enable_run_async_thrift default
true (#3232)
## Motivation
In PR https://github.com/apache/arrow-adbc/pull/3171, `RunAsync` option
in `TExecuteStatementReq` was added and exposed via connection parameter
`adbc.databricks.enable_run_async_thrift`, but it is not enabled by
default. This is turned on by default in other Databricks drivers, we
should turn in on by default in ADBC as well.
## Change
- Set `DatabricksConnection:_runAsyncInThrift` default value to `true`
## Test
- PBI PQTest with all the test cases
---
csharp/src/Drivers/Databricks/DatabricksConnection.cs | 2 +-
csharp/src/Drivers/Databricks/DatabricksParameters.cs | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/csharp/src/Drivers/Databricks/DatabricksConnection.cs
b/csharp/src/Drivers/Databricks/DatabricksConnection.cs
index 14a0eef08..b856c2061 100644
--- a/csharp/src/Drivers/Databricks/DatabricksConnection.cs
+++ b/csharp/src/Drivers/Databricks/DatabricksConnection.cs
@@ -43,7 +43,7 @@ namespace Apache.Arrow.Adbc.Drivers.Databricks
private bool _enableDirectResults = true;
private bool _enableMultipleCatalogSupport = true;
private bool _enablePKFK = true;
- private bool _runAsyncInThrift = false;
+ private bool _runAsyncInThrift = true;
internal static TSparkGetDirectResults defaultGetDirectResults = new()
{
diff --git a/csharp/src/Drivers/Databricks/DatabricksParameters.cs
b/csharp/src/Drivers/Databricks/DatabricksParameters.cs
index 5db14314d..4c0eecd6f 100644
--- a/csharp/src/Drivers/Databricks/DatabricksParameters.cs
+++ b/csharp/src/Drivers/Databricks/DatabricksParameters.cs
@@ -182,7 +182,7 @@ namespace Apache.Arrow.Adbc.Drivers.Databricks
/// <summary>
/// Whether to enable RunAsync flag in Thrift operation
- /// Default value is false if not specified.
+ /// Default value is true if not specified.
/// </summary>
public const string EnableRunAsyncInThriftOp =
"adbc.databricks.enable_run_async_thrift";