This is an automated email from the ASF dual-hosted git repository.
kou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new 6822857775 GH-46831: [C++][R] Remove some pending references to CMake
< 3.25 (docs + minor CMake references) (#46834)
6822857775 is described below
commit 6822857775bafc765b9e75a09e0b7470ce1a957b
Author: Raúl Cumplido <[email protected]>
AuthorDate: Fri Jun 20 13:49:49 2025 +0200
GH-46831: [C++][R] Remove some pending references to CMake < 3.25 (docs +
minor CMake references) (#46834)
### Rationale for this change
Current system requirements is outdated and was not updated to match the
CMake update on:
- https://github.com/apache/arrow/pull/44989
While fixing the above it was noted that there were still other pending
references on some of our codebase (docs + minor CMake)
### What changes are included in this PR?
Update:
- R system requirements to CMake >= 3.25
- Build docs to refer to 3.25
- Update a couple of CMake references
### Are these changes tested?
CI and Archery has been exercised, no new tests are required.
### Are there any user-facing changes?
No
* GitHub Issue: #46831
Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
---
cpp/cmake_modules/ThirdpartyToolchain.cmake | 10 ----------
cpp/examples/minimal_build/CMakeLists.txt | 2 +-
docs/source/developers/cpp/building.rst | 4 ++--
r/DESCRIPTION | 2 +-
4 files changed, 4 insertions(+), 14 deletions(-)
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake
b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index 3dbf0e6048..7191db7104 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -5304,16 +5304,6 @@ endif()
# Azure SDK for C++
function(build_azure_sdk)
- if(CMAKE_VERSION VERSION_LESS 3.22)
- # We can't disable installing Azure SDK for C++ by
- # "set_property(DIRECTORY ${azure_sdk_SOURCE_DIR} PROPERTY
- # EXCLUDE_FROM_ALL TRUE)" with CMake 3.16.
- #
- # At least CMake 3.22 on Ubuntu 22.04 works. So we use 3.22
- # here. We may be able to use more earlier version here.
- message(FATAL_ERROR "Building Azure SDK for C++ requires at least CMake
3.22. "
- "(At least we can't use CMake 3.16)")
- endif()
message(STATUS "Building Azure SDK for C++ from source")
fetchcontent_declare(azure_sdk
${FC_DECLARE_COMMON_OPTIONS}
diff --git a/cpp/examples/minimal_build/CMakeLists.txt
b/cpp/examples/minimal_build/CMakeLists.txt
index 95dad34221..689dba437e 100644
--- a/cpp/examples/minimal_build/CMakeLists.txt
+++ b/cpp/examples/minimal_build/CMakeLists.txt
@@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.
-cmake_minimum_required(VERSION 3.16)
+cmake_minimum_required(VERSION 3.25)
project(ArrowMinimalExample)
diff --git a/docs/source/developers/cpp/building.rst
b/docs/source/developers/cpp/building.rst
index 60a9e06941..8fe8971261 100644
--- a/docs/source/developers/cpp/building.rst
+++ b/docs/source/developers/cpp/building.rst
@@ -41,7 +41,7 @@ Building requires:
* A C++17-enabled compiler. On Linux, gcc 7.1 and higher should be
sufficient. For Windows, at least Visual Studio VS2017 is required.
-* CMake 3.16 or higher
+* CMake 3.25 or higher
* On Linux and macOS, either ``make`` or ``ninja`` build utilities
* At least 1GB of RAM for a minimal build, 4GB for a minimal
debug build with tests and 8GB for a full build using
@@ -451,7 +451,7 @@ several times with different options if you want to
exercise all of them.
CMake version requirements
~~~~~~~~~~~~~~~~~~~~~~~~~~
-We support CMake 3.16 and higher.
+We support CMake 3.25 and higher.
LLVM and Clang Tools
~~~~~~~~~~~~~~~~~~~~
diff --git a/r/DESCRIPTION b/r/DESCRIPTION
index 99470a3cc5..1681480632 100644
--- a/r/DESCRIPTION
+++ b/r/DESCRIPTION
@@ -28,7 +28,7 @@ BugReports: https://github.com/apache/arrow/issues
Encoding: UTF-8
Language: en-US
SystemRequirements: C++17; for AWS S3 support on Linux, libcurl and openssl
(optional);
- cmake >= 3.16 (build-time only, and only for full source build)
+ cmake >= 3.25 (build-time only, and only for full source build)
Biarch: true
Imports:
assertthat,