sivakumar-mahalingam commented on PR #4448: URL: https://github.com/apache/amoro/pull/4448#issuecomment-6336560052
> @sivakumar-mahalingam Thanks for update, The change LGTM. > > Currenty, there is still some little probability that the logic will go wrong when there are more then two users comment `take` on the same issue, but this is a rare case and fix it will add some more complexity. so let's go with the current solution. > > For the concurrency of workflows we can ref to [control-workflow-concurrency](https://docs.github.com/en/actions/how-tos/write-workflows/choose-when-workflows-run/control-workflow-concurrency) Thanks @klion26 for the review and approval! Agreed, the remaining concurrency edge case is rare, and the current implementation addresses the original issue without introducing unnecessary complexity. Thanks also for pointing out GitHub Actions workflow concurrency controls. We can consider further improvements in a separate follow-up if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
