xxubai commented on code in PR #19:
URL: https://github.com/apache/amoro-shade/pull/19#discussion_r4290155228
##########
README.md:
##########
@@ -27,6 +27,38 @@ Shaded dependencies contained here do not expose any
transitive dependencies. Th
When using these dependencies it is recommended to work directly against the
shaded namespaces.
+## 编译与验证
Review Comment:
we need write documents in English
##########
pom.xml:
##########
@@ -67,7 +67,8 @@ under the License.
<properties>
<shading.prefix>org.apache.amoro.shade</shading.prefix>
<guava.version>32.1.1-jre</guava.version>
- <thrift.version>0.20.0</thrift.version>
+ <thrift.version>0.25.0</thrift.version>
Review Comment:
Have you tested running AMS with Thrift `0.25.0` to verify that it is
compatible with the existing service?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
