pallavithegod opened a new pull request, #4444:
URL: https://github.com/apache/amoro/pull/4444

   ## Why are the changes needed?
   Close #1503.
   
   `HMSClientImpl` delegates partition additions, drops, and alterations 
without recording the affected table, partition values, or new location. This 
makes it difficult to trace mixed-Hive partition changes when diagnosing 
metadata or data-location problems.
   
   Log completed mutations at INFO after the metastore call returns. Failed 
operations do not emit success messages; a false drop result or a zero-count 
batch addition is also not reported as a successful change. Existing return 
values and exception behavior are preserved.
   
   ## Brief change log
   - Record single and batch partition additions and alterations, including 
table identity, values, and requested locations.
   - Record successful drops with table identity and partition values.
   - Report the actual batch-add count separately from requested partition 
details.
   - Add coverage for successful operations, failed additions, and no-op 
results.
   
   ## How was this patch tested?
   - [x] Added new unit test cases that verify the changes 
(`TestHMSPartitionLogging`).
   - [x] Verified existing unit tests pass locally (`TestHiveTableTypeUtil`); 
10 selected tests passed in total.
   - [ ] Tested manually in local environment.
   
   Using Java 11:
   - `./mvnw spotless:apply checkstyle:check` passed.
   - `./mvnw test -pl amoro-common -am 
-Dtest=TestHMSPartitionLogging,TestHiveTableTypeUtil 
-Dsurefire.failIfNoSpecifiedTests=false` passed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to