zhoujinsong commented on code in PR #4376:
URL: https://github.com/apache/amoro/pull/4376#discussion_r4002780945
##########
amoro-ams/src/main/java/org/apache/amoro/server/optimizing/OptimizingProcess.java:
##########
@@ -30,6 +30,9 @@ public interface OptimizingProcess {
void close(boolean needCommit);
+ /** Close without committing and persist the reason in the process history.
*/
+ void close(String reason);
Review Comment:
Suggest exposing the full overload as the sole abstract method, with
defaults for the two convenience forms:
```java
void close(boolean needCommit, String reason);
default void close(boolean needCommit) { close(needCommit, null); }
default void close(String reason) { close(false, reason); }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
