czy006 commented on code in PR #4164:
URL: https://github.com/apache/amoro/pull/4164#discussion_r3091156773
##########
amoro-web/src/views/tables/components/Selector.vue:
##########
@@ -81,6 +93,76 @@ async function getConsumerList() {
const result = await getConsumers(props as any)
consumerList.value = (result.list || []).map((l: IServiceBranchItem) => ({
value: l.consumerId, label: l.consumerId, type: branchTypeMap.CONSUMER,
amoroCurrentSnapshotsOfTable: l.amoroCurrentSnapshotsOfTable }))
}
+
+// Open the Create Tag modal
+function openCreateTagModal(e: MouseEvent) {
Review Comment:
[P1] The Create Tag flow is currently unreachable from UI.\n\nReason
summary: `openCreateTagModal` is defined, but there is no template trigger
bound to it, so users cannot actually open the modal and call the new
create-tag API.\n\nSuggested fix: add a visible trigger (for example in the
Tags tab/footer action area) and bind it to `openCreateTagModal`.
##########
amoro-ams/src/main/java/org/apache/amoro/server/dashboard/controller/TableController.java:
##########
@@ -641,6 +641,60 @@ public void getTableTags(Context ctx) {
ctx.json(OkResponse.of(amsPageResult));
}
+ /**
+ * Create a tag manually for an Iceberg table.
+ *
+ * @param ctx - context for handling the request and response
+ */
+ public void createTag(Context ctx) {
Review Comment:
[P2] Missing test coverage for the new tag management API/flow.\n\nReason
summary: this PR adds `POST/DELETE tags`, descriptor logic, and UI changes, but
there are no accompanying tests in backend or frontend for success/error
paths.\n\nSuggested fix: add at least controller/descriptor tests (create
success, duplicate name, invalid snapshot, delete missing tag) and UI
interaction tests (entry visibility, create/delete success/failure feedback).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
