wardlican commented on PR #4174: URL: https://github.com/apache/amoro/pull/4174#issuecomment-4242070538
> Offline nodes with missing `last_update_time` may never be reclaimed > > In `AmsAssignService.detectNodeChanges` (around lines 528-545), a node is marked offline only when `lastUpdateTime > 0 && (currentTime - lastUpdateTime) > nodeOfflineTimeoutMs`. > > However, both `DBBucketAssignStore#getLastUpdateTime` and `ZkBucketAssignStore#getLastUpdateTime` return `0` when the timestamp is missing. In that case, a node that is already absent from the alive-node list will never enter the offline branch, so its buckets are never redistributed. This can leave bucket ownership stranded and prevent load recovery. > > Treat `lastUpdateTime <= 0` as an offline-eligible case when the node is not in `aliveNodeKeys`, and reclaim buckets directly; or Keep a short grace period, but after the grace period, force offline even if timestamp is missing. Okay, I will fix this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
