j1wonpark commented on PR #4045: URL: https://github.com/apache/amoro/pull/4045#issuecomment-4222286794
Thanks for the contribution! I left a few inline comments on dead code and duration recording. One design suggestion: the tag creation logic from `AutoCreateIcebergTagAction` is now inlined into `IcebergTableMaintainer`, which makes the class larger, leaves the original class as dead code, and couples tag creation logic with the maintainer. It might be cleaner to keep `AutoCreateIcebergTagAction` and extend it to support metrics, keeping the responsibilities decoupled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
