Jzjsnow opened a new pull request, #3475:
URL: https://github.com/apache/amoro/pull/3475
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://amoro.apache.org/how-to-contribute/
2. If the PR is related to an issue in
https://github.com/apache/amoro/issues, add '[AMORO-XXXX]' in your PR title,
e.g., '[AMORO-XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][AMORO-XXXX] Your PR title ...'.
-->
## Why are the changes needed?
In [AMORO-3097], we only modified the configuration file template
`amoro-ams/dist/src/main/amoro-bin/conf/config.yaml` in the general deployment,
but did not modify the relevant default parameters in the configuration file
for kubernetes deployments. Further, we did not modify the default values of
the internal parameters `ams.sync-hive-tables.enabled` and
`ams.data-expiration.enabled`, which may lead to invalidation of the defaults
in case of no user configuration.
## Brief change log
<!--
Clearly describe the changes made in modules, classes, methods, etc.
-->
- Improve the default configuration file of helm charts:
`charts/amoro/templates/amoro-configmap.yaml`.
- Modify the default values of the internal management configurations in
class `AmoroManagementConf`.
## How was this patch tested?
- [ ] Add some test cases that check the changes thoroughly including
negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] Run test locally before making a pull request
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs /
not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
