[ 
https://issues.apache.org/jira/browse/AIRFLOW-7031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Noël BARDELOT updated AIRFLOW-7031:
-----------------------------------
    Description: 
In airflow/providers/microsoft/winrm/hooks/winrm.py the following code is 
hardcoded to use 'http' even when the service is set to use 'https':

 
{{ # If endpoint is not set, then build a standard wsman endpoint from host and 
port.}}
{{ if not self.endpoint:}}
{{    self.endpoint = 'http://\{0}:\{1}/wsman'.format(self.remote_host, 
self.remote_port)}}

Workaround: configure the 'enpoint' setting manually in the extra configuration 
of the connection.

Correction: make the protocol configurable, depending on the value of the 
'service' configuration (if 'HTTP' then 'http://' should be used, and if 
'HTTPS' then 'https://' should be used).

  was:
In airflow/providers/microsoft/winrm/hooks/winrm.py the following code is 
hardcoded to use 'http' even when the service is set to use 'https':

 
# If endpoint is not set, then build a standard wsman endpoint from host and 
port.
if not self.endpoint:
   self.endpoint = 'http://\{0}:\{1}/wsman'.format(self.remote_host, 
self.remote_port)

Workaround: configure the 'enpoint' setting manually in the extra configuration 
of the connection.

Correction: make the protocol configurable, depending on the value of the 
'service' configuration (if 'HTTP' then 'http://' should be used, and if 
'HTTPS' then 'https://' should be used).


> Airflow WinRM endpoint is hardcoded to HTTP
> -------------------------------------------
>
>                 Key: AIRFLOW-7031
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-7031
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: hooks
>    Affects Versions: 1.10.9
>            Reporter: Noël BARDELOT
>            Priority: Minor
>
> In airflow/providers/microsoft/winrm/hooks/winrm.py the following code is 
> hardcoded to use 'http' even when the service is set to use 'https':
>  
> {{ # If endpoint is not set, then build a standard wsman endpoint from host 
> and port.}}
> {{ if not self.endpoint:}}
> {{    self.endpoint = 'http://\{0}:\{1}/wsman'.format(self.remote_host, 
> self.remote_port)}}
> Workaround: configure the 'enpoint' setting manually in the extra 
> configuration of the connection.
> Correction: make the protocol configurable, depending on the value of the 
> 'service' configuration (if 'HTTP' then 'http://' should be used, and if 
> 'HTTPS' then 'https://' should be used).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to