pierrejeambrun commented on code in PR #64845:
URL: https://github.com/apache/airflow/pull/64845#discussion_r3079772720
##########
airflow-core/src/airflow/api_fastapi/core_api/openapi/v2-rest-api-generated.yaml:
##########
@@ -6545,6 +6557,20 @@ paths:
schema:
type: string
title: Dag Run Id
+ - name: cursor
+ in: query
+ required: false
+ schema:
+ anyOf:
+ - type: string
+ - type: 'null'
+ description: Cursor for keyset-based pagination (mutually exclusive
with
+ offset). Pass an empty string for the first page, then use
``next_cursor``
+ from the response.
+ title: Cursor
Review Comment:
Actually I thought about this and it's not a breaking change. Spec mentions
`None | int` but using the default 'offset' pagination (which is the default
after this commit and what was used before this commit when no cursor based
pagination was supported) the 'total_entries' field will always be populated
and a non nullable int.
So it doesn't break anything. (unless someone/some tools relies on the
typing, but at runtime it will never be None)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
