imrichardwu commented on code in PR #64926:
URL: https://github.com/apache/airflow/pull/64926#discussion_r3077382158
##########
airflow-core/src/airflow/api_fastapi/core_api/datamodels/ui/deadline.py:
##########
@@ -53,7 +51,6 @@ class DeadlineAlertResponse(BaseModel):
id: UUID
name: str | None = None
- description: str | None = None
Review Comment:
I added this in aprevious pr. No one should have used the api yet, so it
should be ok. I initially decided to add a description because I thought the
same thing on what @ferruzzi was saying above,_ but after talking to @bbovenzi
in my ui pr, we decided to drop it. If I made any mistake in my judgement
@bbovenzi please correct me.
##########
airflow-core/src/airflow/api_fastapi/core_api/datamodels/ui/deadline.py:
##########
@@ -53,7 +51,6 @@ class DeadlineAlertResponse(BaseModel):
id: UUID
name: str | None = None
- description: str | None = None
Review Comment:
I added this in aprevious pr. No one should have used the api yet, so it
should be ok. I initially decided to add a description because I thought the
same thing on what @ferruzzi was saying above, but after talking to @bbovenzi
in my ui pr, we decided to drop it. If I made any mistake in my judgement
@bbovenzi please correct me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
