ferruzzi commented on code in PR #62645: URL: https://github.com/apache/airflow/pull/62645#discussion_r3075529224
########## airflow-core/src/airflow/executors/workloads/__init__.py: ########## @@ -34,13 +34,20 @@ TaskInstance = TaskInstanceDTO +ExecutorWorkload = Annotated[ Review Comment: I see the reasoning, but since it's a union type used in singular annotations like `workload: ExecutorWorkload`, I think singular reads more naturally and it is consistent with how other similar unions in the codebase like `CallbackRequest`, `TIStateUpdate`, `ToManager`, etc. are named. Happy to change it if you feel strongly, but that was my reasoning FWIW. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
