vincbeck commented on code in PR #64539:
URL: https://github.com/apache/airflow/pull/64539#discussion_r3073144223
##########
providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py:
##########
@@ -1495,15 +1495,23 @@ def update_user(self, user: User) -> bool:
new_group_ids = {grp.id for grp in user.groups}
if existing_role_ids != new_role_ids or existing_group_ids !=
new_group_ids:
user.changed_on =
datetime.datetime.now(tz=datetime.timezone.utc)
- self.session.merge(user)
+ merged_user = self.session.merge(user)
self.session.commit()
+ self._reset_user_permissions_cache(user)
+ if merged_user is not user:
+ self._reset_user_permissions_cache(merged_user)
Review Comment:
Cannot we just do that?
```suggestion
self._reset_user_permissions_cache(merged_user)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
