amoghrajesh opened a new pull request, #65126:
URL: https://github.com/apache/airflow/pull/65126
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes - Cursor
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
Follow up to: https://github.com/apache/airflow/pull/64767
`TestExecutorConf` class uses `conf.read_string()` to temporarily set config
values for testing, but it never cleans them up. This leaks config state into
subsequent tests and pollutes the `conf` instance.
When https://github.com/apache/airflow/pull/64767 which added SSL validation
to `CeleryExecutor`, the leaked `ssl_active=true` from
`test_executor_conf_getboolean()` triggered a `ValueError` during executor
initialization in unrelated tests like `test_executor_loader`, leading to
errors like:
```
_________________________________________________________________________________
TestExecutorLoader.test_init_executors
_________________________________________________________________________________
[gw3] linux -- Python 3.10.20 /usr/local/bin/python3
airflow-core/tests/unit/executors/test_executor_loader.py:323: in
test_init_executors
executors = executor_loader.ExecutorLoader.init_executors()
airflow-core/src/airflow/executors/executor_loader.py:304: in init_executors
loaded_executor = cls.load_executor(executor_name)
airflow-core/src/airflow/executors/executor_loader.py:368: in load_executor
executor = executor_cls()
providers/celery/src/airflow/providers/celery/executors/celery_executor.py:137:
in __init__
self.celery_app = create_celery_app(self.conf)
providers/celery/src/airflow/providers/celery/executors/celery_executor_utils.py:143:
in create_celery_app
config = get_default_celery_config(team_conf)
providers/celery/src/airflow/providers/celery/executors/default_celery.py:150:
in get_default_celery_config
raise ValueError(
E ValueError: SSL_MUTUAL_TLS is True (default) but SSL_KEY and/or SSL_CERT
are not set. Set both for mutual TLS, or set SSL_MUTUAL_TLS=False for one-way
TLS.
```
in https://github.com/apache/airflow/actions/runs/24325740827/job/71021649692
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
