potiuk opened a new pull request, #65108:
URL: https://github.com/apache/airflow/pull/65108
The `build-docs` job in `publish-docs-to-s3.yml` was rebuilding the CI image
from scratch on
every run because it never logged in to `ghcr.io`, so Buildx could not reach
the registry
cache tag (`<image>:cache-<platform>`) that the main "Test" workflow pushes
via
`push-image-cache.yml`. The manual `docker buildx build` fallback also had
no `--cache-from`
and a hardcoded `python3.9` tag that no longer matched the Python version
used for the docs
build.
## Summary
- Add a `docker login ghcr.io` step in `build-docs` so `breeze ci-image
build` can actually
pull the registry buildx cache published by the last "main" Test workflow.
- Set `DOCKER_CACHE=registry` and `PYTHON_MAJOR_MINOR_VERSION` explicitly on
the job so the
cache lookup is deterministic and matches `default-python-version`.
- Grant `packages: read` to the `build-docs` job.
- Fix the stale `python3.9` tag in the buildx fallback so it derives from
`PYTHON_MAJOR_MINOR_VERSION`.
- Refresh the two comments that still claimed the job "will not use cache"
and explain why
the fallback path (no `--cache-from`) still exists for old refs whose
`pyproject.toml` has
drifted from main.
The fast path now hits the same registry cache the main Test workflow
pushes; the fallback
is untouched and still handles the old-ref drift case.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (Opus 4.6)
Generated-by: Claude Code (Opus 4.6) following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
