rjgoyln opened a new pull request, #65065:
URL: https://github.com/apache/airflow/pull/65065

   ## Summary
   This PR fixes a logic error where `jobs list` unintentionally filtered out 
active jobs because the `is_alive` parameter defaulted to `False`. By 
implementing three-state logic (True/False/None) and setting the default to 
`None`, the command now correctly returns all jobs unless an explicit filter is 
applied.
   
   ## Changes
   - **CLI Configuration**: Updated the argument generation logic to set 
`arg_default=None` for boolean parameters to distinguish between "not 
specified" and "explicitly false."
   - **Operations Layer**: Refactored `JobsOperations.list` to use a dynamic 
parameter mapping, ensuring `is_alive` is only sent to the API if explicitly 
set by the user.
   - **Type Safety**: Improved type handling to support `bool | None` 
(Optional[bool]) and fixed Mypy type mismatch errors in the parameter 
dictionary.
   - **Testing**: Added  unit tests to verify that `CommandFactory` correctly 
generates `BooleanOptionalAction` with a `None` default for optional boolean 
fields.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, 
please
   change below checkbox to `[X]` followed by the name of the tool, uncomment 
the "Generated-by".
   -->
   
   - [ ] Yes (please specify the tool below)
   
   <!--
   Generated-by: [Tool Name] following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   -->
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to