kakatur commented on code in PR #64745:
URL: https://github.com/apache/airflow/pull/64745#discussion_r3068197108
##########
providers/amazon/src/airflow/providers/amazon/aws/operators/batch.py:
##########
@@ -257,9 +259,14 @@ def execute_complete(self, context: Context, event:
dict[str, Any] | None = None
self.job_id = validated_event["job_id"]
- # Fetch logs if awslogs_enabled
+ # Fetch logs and persist links if awslogs_enabled, otherwise just
persist links
if self.awslogs_enabled:
- self.monitor_job(context) # fetch logs, no need to return
+ # monitor_job() handles link persistence, log fetching, and
success check
+ self.monitor_job(context)
+ else:
+ # Persist operator links and check job success
+ self._persist_links(context)
+ self.hook.check_job_success(self.job_id)
Review Comment:
Removed redundant _persist_links() call in execute_complete() when
awslogs_enabled=False (line 268).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
