cruseakshay commented on code in PR #62772:
URL: https://github.com/apache/airflow/pull/62772#discussion_r3067626645
##########
providers/microsoft/azure/src/airflow/providers/microsoft/azure/operators/container_instances.py:
##########
@@ -407,24 +444,65 @@ def execute(self, context: Context) -> int:
raise AirflowException("Could not start container group")
finally:
- if exit_code == 0 or self.remove_on_error:
- self.on_kill()
+ if _cleanup:
+ if exit_code == 0 and self.remove_on_success:
+ self.on_kill()
+ elif exit_code != 0 and self.remove_on_error:
+ self.on_kill()
def on_kill(self) -> None:
self.log.info("Deleting container group")
try:
- self._ci_hook.delete(self.resource_group, self.name)
+ self.hook.delete(self.resource_group, self.name)
except Exception:
self.log.exception("Could not delete container group")
+ def execute_complete(self, context: Context, event: dict[str, Any] | None)
-> int:
+ """
+ Handle the trigger event after deferral.
+
+ Called by the Triggerer when the container reaches a terminal state.
+ Raises on failure; returns the exit code on success.
+ """
+ if event is None:
+ raise ValueError("Trigger error: event is None")
+
+ exit_code: int = event.get("exit_code", 1)
+
+ if event["status"] == "error":
+ if self.remove_on_error:
+ self.on_kill()
+ raise RuntimeError(
+ event.get(
+ "message",
+ f"Container group {self.resource_group}/{self.name} failed
with exit code {exit_code}",
+ )
+ )
Review Comment:
Added as nailo2c review suggestions: Don't use AirflowException directly —
use standard Python exceptions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
