Miretpl commented on code in PR #65027:
URL: https://github.com/apache/airflow/pull/65027#discussion_r3066887527
##########
helm-tests/tests/helm_tests/airflow_aux/test_pod_template_file.py:
##########
@@ -1043,29 +1043,82 @@ def test_safe_to_evict_annotation_other_services(self,
workers_values):
annotations =
jmespath.search("spec.template.metadata.annotations", doc)
assert
annotations.get("cluster-autoscaler.kubernetes.io/safe-to-evict") == "true"
- def test_workers_pod_annotations(self):
+ def test_global_pod_annotations_templated(self):
docs = render_chart(
- values={"workers": {"podAnnotations": {"my_annotation":
"annotated!"}}},
+ values={"airflowPodAnnotations": {"global": "{{ .Release.Name
}}"}},
show_only=["templates/pod-template-file.yaml"],
chart_dir=self.temp_chart_dir,
)
+
annotations = jmespath.search("metadata.annotations", docs[0])
- assert "my_annotation" in annotations
- assert "annotated!" in annotations["my_annotation"]
+ assert len(annotations) == 2 # safe-to-evict + extra annotation
Review Comment:
Yup, I changed that in other PRs and haven't gone through all of them yet,
so it will be fixed before marking it as ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
