choo121600 commented on code in PR #63969:
URL: https://github.com/apache/airflow/pull/63969#discussion_r3062368851
##########
airflow-core/src/airflow/ui/tests/e2e/pages/XComsPage.ts:
##########
Review Comment:
To reduce flakiness, how about explicitly checking that the button is in an
interactable state before clicking it?
(For example, by adding an assertion like toBeEnabled.)
##########
airflow-core/src/airflow/ui/tests/e2e/pages/XComsPage.ts:
##########
@@ -57,14 +57,13 @@ export class XComsPage extends BasePage {
await filterInput.waitFor({ state: "visible", timeout: 5000 });
Review Comment:
Using web assertions like `expect().toBeVisible()` would be better than
.`waitFor()`.
Writing tests with assertions makes the cause of failures clearer, which
also helps when debugging flaky tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
