xBis7 commented on code in PR #64902:
URL: https://github.com/apache/airflow/pull/64902#discussion_r3058338888
##########
dev/breeze/src/airflow_breeze/utils/kubernetes_utils.py:
##########
@@ -386,29 +394,42 @@ def set_random_cluster_ports(python: str,
kubernetes_version: str, output: Outpu
"""
forwarded_port_number = _get_free_port()
k8s_api_server_port = _get_free_port()
+ jaeger_port_number = _get_free_port()
Review Comment:
Ports are allocated and exported regardless of whether the service starts or
not. If this doesn't take place here and the user later decides to upgrade the
cluster with the observability services, the container will need to be
recreated with the ports.
##########
chart/values.yaml:
##########
@@ -3926,10 +3963,15 @@ config:
remote_logging: '{{- ternary "True" "False" (or
.Values.elasticsearch.enabled .Values.opensearch.enabled) }}'
colored_console_log: 'False'
metrics:
- statsd_on: '{{ ternary "True" "False" .Values.statsd.enabled }}'
+ statsd_on: '{{ ternary "True" "False" (and .Values.statsd.enabled (not
.Values.otelCollector.metricsEnabled)) }}'
Review Comment:
The config property is set to `False` if `otelCollector.metricsEnabled` is
true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
