jason810496 commented on code in PR #64905: URL: https://github.com/apache/airflow/pull/64905#discussion_r3051753103
########## airflow-core/tests/unit/migrations/test_migration_utils.py: ########## @@ -0,0 +1,102 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +""" +Stairway test for Airflow DB migrations. + +Walks every individual migration step forward (upgrade) then backward (downgrade) +to verify that all migrations are fully reversible. This catches problems like: +- a migration that creates a constraint the downgrade forgets to drop +- a downgrade that references a column that was never added by the upgrade + +The test starts from the squashed baseline (revision 4bc4d934e2bc, the 2.6.2 +snapshot) and iterates through each revision in topological order. +""" + +from __future__ import annotations + +import pytest +from alembic import command +from alembic.script import ScriptDirectory + +from airflow.utils.db import _get_alembic_config + +pytestmark = pytest.mark.db_test + +# The squashed "start-of-history" revision – stairway starts here. +_SQUASHED_BASE_REVISION = "4bc4d934e2bc" Review Comment: Should this revision import from core instead of hard coded here? ########## airflow-core/tests/unit/migrations/test_migration_utils.py: ########## @@ -0,0 +1,102 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +""" +Stairway test for Airflow DB migrations. + +Walks every individual migration step forward (upgrade) then backward (downgrade) +to verify that all migrations are fully reversible. This catches problems like: +- a migration that creates a constraint the downgrade forgets to drop +- a downgrade that references a column that was never added by the upgrade + +The test starts from the squashed baseline (revision 4bc4d934e2bc, the 2.6.2 +snapshot) and iterates through each revision in topological order. Review Comment: Just FYI that we define the revision here: https://github.com/apache/airflow/blob/498acc8cf269e3ec2717eec25483aac7bf344533/airflow-core/src/airflow/utils/db.py#L105-L120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
