mobuchowski commented on code in PR #64843:
URL: https://github.com/apache/airflow/pull/64843#discussion_r3051231911
##########
providers/openlineage/src/airflow/providers/openlineage/extractors/manager.py:
##########
@@ -142,9 +142,26 @@ def extract_metadata(
task_info,
)
self.log.debug("OpenLineage extraction failure details:",
exc_info=True)
- elif (hook_lineage := self.get_hook_lineage(task_instance,
task_instance_state)) is not None:
- return hook_lineage
else:
+ # No extractor found — fall back to hook lineage. This call must
be wrapped in
+ # try/except: it runs emit_lineage_from_sql_extras →
_create_ol_event_pair which
+ # is not guarded internally. An uncaught exception here would
propagate into
+ # on_success()'s @print_warning, silently suppressing the
task-level COMPLETE event.
Review Comment:
Fixed the comment/log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
