potiuk commented on code in PR #64774:
URL: https://github.com/apache/airflow/pull/64774#discussion_r3040460778
##########
scripts/in_container/install_airflow_and_providers.py:
##########
@@ -1127,7 +1128,8 @@ def _install_airflow_and_optionally_providers_together(
"install",
]
if installation_spec.pre_release:
- base_install_cmd.append("--pre")
+ console.print("[bright_blue]Allowing pre-release versions of airflow
and providers")
+ base_install_cmd.extend(["--pre", "--exclude-newer",
datetime.now().isoformat()])
Review Comment:
```suggestion
base_install_cmd.extend(["--pre", "--frozen", "--exclude-newer",
datetime.now().isoformat()])
```
##########
scripts/in_container/install_airflow_and_providers.py:
##########
@@ -1223,8 +1225,8 @@ def
_install_only_airflow_airflow_core_task_sdk_with_constraints(
"install",
]
if installation_spec.pre_release:
- console.print("[bright_blue]Allowing pre-release versions of airflow")
- base_install_airflow_cmd.append("--pre")
+ console.print("[bright_blue]Allowing pre-release versions of airflow
and providers")
+ base_install_airflow_cmd.extend(["--pre", "--exclude-newer",
datetime.now().isoformat()])
Review Comment:
Righ tnot needed - those installations use constraints already , not uv.lock
##########
scripts/in_container/install_airflow_and_providers.py:
##########
@@ -1223,8 +1225,8 @@ def
_install_only_airflow_airflow_core_task_sdk_with_constraints(
"install",
]
if installation_spec.pre_release:
- console.print("[bright_blue]Allowing pre-release versions of airflow")
- base_install_airflow_cmd.append("--pre")
+ console.print("[bright_blue]Allowing pre-release versions of airflow
and providers")
+ base_install_airflow_cmd.extend(["--pre", "--exclude-newer",
datetime.now().isoformat()])
Review Comment:
```suggestion
base_install_airflow_cmd.extend(["--pre", "--frozen",
"--exclude-newer", datetime.now().isoformat()])
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
