eladkal commented on code in PR #64591:
URL: https://github.com/apache/airflow/pull/64591#discussion_r3027167348


##########
providers/zendesk/provider.yaml:
##########
@@ -78,7 +78,6 @@ connection-types:
       hidden-fields:
         - schema
         - port
-        - extra

Review Comment:
   I don't know if this is how it should be implemented.
   
   I suggest to check how we add and access custom fields in Snowflake
   
https://github.com/apache/airflow/blob/84f6ee0cf8eb9205cd06d38ba1986b43f1734779/providers/snowflake/provider.yaml
   
https://github.com/apache/airflow/blob/c2fe5544de70dc70e4ecbd9e84f0284de28af953/providers/snowflake/src/airflow/providers/snowflake/hooks/snowflake.py
   
   We want users to have a nice UI form that guides them how to setup the 
connection



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to