nagasrisai commented on code in PR #64575:
URL: https://github.com/apache/airflow/pull/64575#discussion_r3026116631
##########
providers/salesforce/src/airflow/providers/salesforce/operators/bulk.py:
##########
@@ -72,6 +91,9 @@ def __init__(
self.batch_size = batch_size
self.use_serial = use_serial
self.salesforce_conn_id = salesforce_conn_id
+ self.max_retries = max_retries
+ self.retry_delay = retry_delay
+ self.transient_error_codes = frozenset(transient_error_codes)
self._validate_inputs()
Review Comment:
added validation for all three parameters. `max_retries` and `retry_delay`
are checked in `_validate_inputs()` and raise a `ValueError` if negative. The
string check for `transient_error_codes` had to go in `__init__` *before* the
`frozenset()` call, because once it's already been converted you can't tell a
string was passed, iterating over a string gives you individual characters
silently, which would be a confusing bug. All three raise a clear error message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
