ahilashsasidharan commented on PR #63994: URL: https://github.com/apache/airflow/pull/63994#issuecomment-4174648982
Question for @o-nikolas and others: I pushed an implementation that moves the check to `airflow-core/src/airflow/api_fastapi/core_api/routes/public/` instead of in `airflow-core/src/airflow/api_fastapi/core_api/datamodels/`. After some initial testing, both implementation work, so I wanted some feedback on which one is preferred. Looking at the code I feel under` routes/public` might be more appropriate for this type of check, but it requires more code spread across each file including additional code to handle checking bulk requests. On the other hand the `datamodel `approach is simpler and reviewers were previously fine with it. Happy to go with whichever is preferred. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
