Copilot commented on code in PR #64265:
URL: https://github.com/apache/airflow/pull/64265#discussion_r3025327407
##########
providers/google/src/airflow/providers/google/marketing_platform/sensors/campaign_manager.py:
##########
@@ -79,7 +79,7 @@ def __init__(
profile_id: str,
report_id: str,
file_id: str,
- api_version: str = "v4",
+ api_version: str = "v5",
Review Comment:
Changing the default `api_version` from v4 to v5 is behavior-changing and
the existing unit test hard-codes `API_VERSION = "v4"`
(providers/google/tests/unit/google/marketing_platform/sensors/test_campaign_manager.py).
Please update/add a test that asserts the new default (i.e., omit
`api_version` and verify the hook is instantiated with v5), and keep the
explicit-version test if needed.
##########
providers/google/src/airflow/providers/google/marketing_platform/sensors/campaign_manager.py:
##########
@@ -44,7 +44,7 @@ class GoogleCampaignManagerReportSensor(BaseSensorOperator):
:param profile_id: The DFA user profile ID.
:param report_id: The ID of the report.
:param file_id: The ID of the report file.
- :param api_version: The version of the api that will be requested, for
example 'v4'.
+ :param api_version: The version of the api that will be requested, for
example 'v5'.
Review Comment:
The parameter docs now reference API version v5, but this docstring still
links to the v4 REST docs (`.../rest/v4/reports/get`) earlier in the same
docstring. Please update the URL to v5 (or make it version-agnostic) so
documentation matches the new default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
