Fury0508 commented on code in PR #61729:
URL: https://github.com/apache/airflow/pull/61729#discussion_r3017398745
##########
task-sdk/src/airflow/sdk/templates/email/task_failure_body.html:
##########
@@ -0,0 +1,113 @@
+{#
Review Comment:
Hi @eladkal, thank you for the clarification that makes total sense given
the email migration out of core (#30531).
I'll pivot the approach:
- Remove all template files from `task-sdk` and revert any changes to
`task_runner.py`
- Instead, improve the default templates in the smtp provider at
`providers/smtp/src/airflow/providers/smtp/notifications/templates/` (updating
`email_subject.jinja2` and `email_content.jinja2`)
- Rebase the branch on latest `main`
I'll have the updated PR ready within 2 days. Will ping here once it's ready
for 2nd review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
