uranusjr commented on code in PR #55169:
URL: https://github.com/apache/airflow/pull/55169#discussion_r2318398705
##########
airflow-core/tests/unit/models/test_dagrun.py:
##########
@@ -570,21 +544,15 @@ def test_end_dr_span_if_needed(self, testing_dag_bundle,
dag_maker, session):
schedule=datetime.timedelta(days=1),
start_date=datetime.datetime(2017, 1, 1),
) as dag:
- ...
- SerializedDAG.bulk_write_to_db("testing", None, dags=[dag],
session=session)
-
- dag_task1 = EmptyOperator(task_id="test_task1", dag=dag)
- dag_task2 = EmptyOperator(task_id="test_task2", dag=dag)
- dag_task1.set_downstream(dag_task2)
+ dag_task1 = EmptyOperator(task_id="test_task1")
+ dag_task2 = EmptyOperator(task_id="test_task2")
+ dag_task1.set_downstream(dag_task2)
initial_task_states = {
"test_task1": TaskInstanceState.SUCCESS,
"test_task2": TaskInstanceState.SUCCESS,
}
- # Scheduler uses Serialized DAG -- so use that instead of the Actual
DAG
- dag = SerializedDAG.from_dict(SerializedDAG.to_dict(dag))
Review Comment:
Yes it does. This (and other tests in this file) just re-serialise the
already serialised dag. I’m actually surprised they didn’t break when I changed
the serialised dag thing, but either case they are failing now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
