HsiuChuanHsu opened a new pull request, #55159:
URL: https://github.com/apache/airflow/pull/55159
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
## Description
This PR fixes issue #49517 where TaskInstanceHistory records were lost when
Kubernetes API rate limiting (429 errors) prevented task adoption during
scheduler restarts.
## Problem
When using KubernetesExecutor or CeleryKubernetesExecutor:
1. Task pods launch successfully but K8s API starts returning 429 errors
2. KubernetesJobWatcher crashes, causing Scheduler restart
3. Scheduler fails to re-adopt running pods due to continued 429s
4. Tasks are marked orphaned with state reset to `None`
5. TaskInstanceHistory is not recorded since state ≠ `RUNNING`
6. Airflow UI shows missing log links for failed attempts
## Solution
**KubernetesExecutor**: Add 429 error handling to retry logic and detailed
logging for adoption failures
**TaskInstance**: Detect orphaned tasks (`state=None` + `start_date set` +
`end_date unset` ) and record TaskInstanceHistory
## Impact
**Before**:
Task Running → K8s API 429 → Scheduler Restart → Task Orphaned → State Reset
to None →
No History → Missing UI Logs
**After**:
Task Running → K8s API 429 → Scheduler Restart → Task Orphaned → State Reset
to None →
History Recorded → UI Logs Available
Fixes: #49517
Related: #49244
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
