ashb commented on code in PR #53831:
URL: https://github.com/apache/airflow/pull/53831#discussion_r2284581141
##########
airflow-core/tests/unit/models/test_deadline.py:
##########
@@ -87,19 +98,7 @@ def setup_method():
def teardown_method():
_clean_db()
- def test_add_deadline(self, dagrun, session):
- assert session.query(Deadline).count() == 0
- deadline_orm = Deadline(
- deadline_time=DEFAULT_DATE,
- callback=TEST_ASYNC_CALLBACK,
- dagrun_id=dagrun.id,
- )
-
- session.add(deadline_orm)
- session.flush()
-
- assert session.query(Deadline).count() == 1
-
+ def test_add_deadline(self, dagrun, deadline_orm, session):
Review Comment:
That sounds very much like we are testing SQLA here. We should assume it has
it's own unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
