potiuk commented on PR #54070:
URL: https://github.com/apache/airflow/pull/54070#issuecomment-3172892790

   > I will check where should I add the  breeze compile-ui-assets or how to 
compile the frontend before start-airflow when I have time tomorrow.
   
   Yes- that is a missing thing. The problem with it is that we currently run 
asset compilation outside of breeze - but the installation with 
`--use-airflow-version` already happens fully in breeze. And we have no 
`node/yarn/pnpm` installed in CI image....  The problem is that when we install 
from GitHub URL - we do not have local sources (which would be a different 
version) so even if you could run `breeze` command inside `breeze` (technically 
such inception shoud be possible- because we also forward docker socket to 
inside breeze) - what you really need is you need to:
   
   1) install node + yarn + pnpm
   2) find the directory in `site-packages` where airflow UI javascript sources 
are installed
   3) run appropriate npm commands 
   
   
   Not a rocket science but it will take a bit of time to run, and it shoudl be 
done somewhere here: 
https://github.com/apache/airflow/blob/main/scripts/in_container/install_airflow_and_providers.py#L767
 -> this is where the command to install stuff when `--use-airflow-version` is 
actually executed - and "airflow-core" should be installed right after - you 
should probably naed to add a flag in the InstallationSpec (`compile_assets`) 
and set it to true somewhere here - 
https://github.com/apache/airflow/blob/main/scripts/in_container/install_airflow_and_providers.py#L325
 - because this is where we determine what "pip install" to add based on the 
`--use-airflow` flag.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to