jason810496 commented on PR #53356: URL: https://github.com/apache/airflow/pull/53356#issuecomment-3171927376
Sorry for the late reply. > ASB always goes for the callback method and does not really return anything else (the only way we can make it work similar to the redis implementation is by updating the hook but it seems out of scope for this) IMO, this is what I mention "no need to be restricted with existed implementation of `BaseAzureServiceBusHook`". Adding a new method that just raise `TriggerEvent` without callback will be much more simpler and align behavior of other providers. > I get the concern of the coupling with the MessageHook interfaces but given its implementation its really hard to decouple anything that we build using it. Yes, so this is why I suggest to add a new method ( maybe named as `read_message` ) to decouple the "callback" and get rid of `asyncio.Queue`. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
