gyli commented on code in PR #47592: URL: https://github.com/apache/airflow/pull/47592#discussion_r2258841270
########## airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_import_error.py: ########## Review Comment: I don't think scope session is suitable to fixture with db insertion. I don't find existing db-related fixture that is session scoped. More importantly, there are many tests cleanup dag bundle or reset db at the end of the test. Even if those tests are updated in this PR, nothing can prevent fixture `clear_db_dag_bundles` or `reset_db` being used in the future. If they are used, it would be unnecessarily tricky to re-create dag bundles using session-scoped fixture. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
