pierrejeambrun commented on code in PR #53943:
URL: https://github.com/apache/airflow/pull/53943#discussion_r2244721758
##########
airflow-core/src/airflow/api_fastapi/core_api/services/public/connections.py:
##########
@@ -56,11 +59,24 @@ def update_orm_from_pydantic(
if (not update_mask and "password" in pydantic_conn.model_fields_set) or (
update_mask and "password" in update_mask
):
- orm_conn.set_password(pydantic_conn.password)
+ if pydantic_conn.password is None:
+ orm_conn.set_password(pydantic_conn.password)
+ return
+
+ merged_password = merge(pydantic_conn.password, orm_conn.password,
"password")
+ orm_conn.set_password(merged_password)
Review Comment:
You're right, that's not correct, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
