shahar1 commented on code in PR #53726:
URL: https://github.com/apache/airflow/pull/53726#discussion_r2232797683
##########
airflow-core/src/airflow/secrets/local_filesystem.py:
##########
@@ -233,10 +233,23 @@ def load_variables(file_path: str) -> dict[str, str]:
log.debug("Loading variables from a text file")
secrets = _parse_secret_file(file_path)
- invalid_keys = [key for key, values in secrets.items() if
isinstance(values, list) and len(values) != 1]
- if invalid_keys:
- raise AirflowException(f'The "{file_path}" file contains multiple
values for keys: {invalid_keys}')
- variables = {key: values[0] if isinstance(values, list) else values for
key, values in secrets.items()}
+
+ # Determine a file format to handle lists correctly
+ ext = file_path.rsplit(".", 2)[-1].lower()
Review Comment:
I'd rather use `Pathlib` method to determine file's suffix rather than
string manipulation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
