ramitkataria commented on code in PR #53201:
URL: https://github.com/apache/airflow/pull/53201#discussion_r2216505021
##########
airflow-core/src/airflow/jobs/triggerer_job_runner.py:
##########
@@ -589,7 +589,7 @@ def update_triggers(self, requested_trigger_ids: set[int]):
cancel_trigger_ids = self.running_triggers - requested_trigger_ids
# Bulk-fetch new trigger records
new_triggers = Trigger.bulk_fetch(new_trigger_ids)
- triggers_with_assets = Trigger.fetch_trigger_ids_with_asset()
+ trigger_ids_with_non_task_associations =
Trigger.fetch_trigger_ids_with_non_task_associations()
Review Comment:
I thought about that earlier as well but I changed it because it may imply
that `non_task_triggers` includes all triggers where `task_instance` is `None`
(regardless of whether they have an asset or a deadline). Another one I
considered was `non_task_active_triggers` but I wasn't sure if calling them
"active" is a good idea either because this is before a `workload` is created
for them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
