potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2212544266


##########
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_dags.py:
##########
@@ -58,6 +63,7 @@ class TestDagEndpoint:
 
     @staticmethod
     def _clear_db():
+        clear_db_connections()

Review Comment:
   See above - this one is **clearly** good to have and simply missing. Those 
thests rely on test git connection not present in the DB - so it's a good 
practice to clear the connection table to avoid accidental side-effects from 
other tests - we clear other tables in the next line, so clearing the 
connection tablee **should** be added here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to