kyungjunleeme commented on code in PR #53407:
URL: https://github.com/apache/airflow/pull/53407#discussion_r2212006473
##########
providers/http/src/airflow/providers/http/hooks/http.py:
##########
@@ -172,7 +175,7 @@ def get_conn(
:return: A configured requests.Session object.
"""
session = Session()
- connection = self.get_connection(self.http_conn_id)
+ connection = self.get_connection(self.get_conn_id())
Review Comment:
at first, Thanks ur commeting about my pr. :)
I recently worked on [this
PR](https://github.com/apache/airflow/pull/53335), and I believe the same
approach could be applied more broadly.
I'd like to take a bit more time to think it through, and then I'll request
your review again. I think there's value in discussing it together to identify
meaningful improvements.
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
