potiuk commented on code in PR #46891:
URL: https://github.com/apache/airflow/pull/46891#discussion_r2211838550
##########
providers/amazon/pyproject.toml:
##########
@@ -95,9 +96,12 @@ dependencies = [
"s3fs>=2023.10.0",
]
"python3-saml" = [
- "python3-saml>=1.16.0",
- "xmlsec>=1.3.14",
- "lxml>=6.0.0",
+ # Python 3 saml is not compatible with Python 3.13 yet, so we pin it to <
3.13
+ "python3-saml>=1.16.0; python_version < \"3.13\"",
+ # python3-saml is dependent on xmlsec and seems they do not pin it,
pinning here would be needed
+ # We can remove it after
https://github.com/xmlsec/python-xmlsec/issues/344 is fixed
+ "xmlsec>=1.3.14; python_version < \"3.13\"",
+ "lxml>=6.0.0; python_version < \"3.13\"",
Review Comment:
Oh absolutely. I don't even realised they are used non-consistently. Likely
I just copied it from elsewhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
