ashb commented on code in PR #53149: URL: https://github.com/apache/airflow/pull/53149#discussion_r2202547648
########## task-sdk/src/airflow/sdk/_vendor/.gitignore: ########## @@ -0,0 +1 @@ +*/*.py Review Comment: We do have a quirk we have to avoid here -- if we have `shared/logging/src/logging/__init__.py` this would end up conflicting with the stdlib in dev using this approach. Perhaps another reason to suggest relative imports. I guess the main issue with relative imports is are we okay with no imports between shared libs? For example, it might be nice to be able to use the timezone/date parsing stuff in the logging one, but I don't think we can do that when symlinking? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
