jroachgolf84 commented on PR #53100: URL: https://github.com/apache/airflow/pull/53100#issuecomment-3053685713
> Attributes are frequently added to hooks around the code base with no similar issues. If sftp provider is sensitive to changes made to ssh hook then the sftp provider needs to have proper testing to avoid such future problems. Will the sftp code break again if tomorrow attribute x is added to SSHHook? The issue here is that the `SFTPHook` adds the `host_proxy_cmd` to `kwargs`, then passes `kwargs` to `super().__init__(...)` (the `SSHHook`). It was the addition of the `host_proxy_cmd` that broke the older version of the `SSHHook`. With the newer version of the `SSHHook`, `host_proxy_cmd` was added as an attribute. I could be a bit confused here; where would you suggest making a change/adding a test (there are already tests that cover the instantiation of the `SFTPHook`, which in turn instantiates the `SSHHook`)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
