eladkal commented on code in PR #53000:
URL: https://github.com/apache/airflow/pull/53000#discussion_r2195514312
##########
airflow-core/src/airflow/utils/state.py:
##########
@@ -213,7 +213,7 @@ def color_fg(cls, state):
"""
success_states: frozenset[TaskInstanceState] = frozenset(
- [TaskInstanceState.SUCCESS, TaskInstanceState.SKIPPED]
+ [TaskInstanceState.SUCCESS, TaskInstanceState.SKIPPED,
TaskInstanceState.REMOVED]
Review Comment:
I don't know if this right. The PR description doesn't explain about
refactoring to removed state and motivation for it. Please don't do such
changes on the fly. This is the very heart of Airflow - doing things wrong here
may result in yanking a release.
Given dag versioning, I am not sure what removed state means or if it's even
possible to have a task in removed state? in any case best to keep this in a
separate PR to not lose focus of separated topics
##########
airflow-core/src/airflow/api_fastapi/execution_api/datamodels/taskinstance.py:
##########
@@ -66,6 +66,7 @@ class TerminalStateNonSuccess(str, Enum):
FAILED = TerminalTIState.FAILED
SKIPPED = TerminalTIState.SKIPPED
REMOVED = TerminalTIState.REMOVED
+ UPSTREAM_FAILED = "upstream_failed"
Review Comment:
Why hard coded string?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
